[RFC PATCH v12 5/5] arm64: dts: rockchip: Move PCIe WAKE# irq to pcie port for Gru
From: tony@atomide.com (Tony Lindgren)
Date: 2017-12-29 17:55:46
Also in:
linux-devicetree, linux-pm, linux-rockchip, lkml
* Jeffy Chen [off-list ref] [171226 02:41]:
Currently we are handling PCIe WAKE# irq in mrvl wifi driver. Move it to rockchip pcie port since we are going to handle it in the pci core.
Yes in the PCIe case, the pcie port node is the right place for the wakeirq instead of the child the mvl_wifi node. So one question further down below to verify this..
Also avoid this irq been considered as the PCI interrupt pin in the of_irq_parse_pci().
The above paragraph needs a bit more clarification to be readable :)
quoted hunk ↗ jump to hunk
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi@@ -719,15 +719,16 @@ ap_i2c_audio: &i2c8 { #size-cells = <2>; ranges; + interrupts-extended = <&pcie0 1>, <&gpio0 8 IRQ_TYPE_LEVEL_LOW>; + interrupt-names = "pci", "wakeup"; + pinctrl-names = "default"; + pinctrl-0 = <&wlan_host_wake_l>; + wakeup-source; + mvl_wifi: wifi at 0,0 { compatible = "pci1b4b,2b42"; reg = <0x83010000 0x0 0x00000000 0x0 0x00100000 0x83010000 0x0 0x00100000 0x0 0x00100000>; - interrupt-parent = <&gpio0>; - interrupts = <8 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names = "default"; - pinctrl-0 = <&wlan_host_wake_l>; - wakeup-source; }; }; };
So the above modifies pcie at 0,0 node. And that node describes the particular PCIe port that the WLAN is connected to instead of describing the whole PCIe controller device, right? If so, then yeah it's totally where the wakeirq should be defined for a PCIe device in the dts file :) Regards, Tony