On Mon, Dec 18, 2017 at 8:02 PM, C?dric Le Goater [off-list ref] wrote:

quoted

+};
+
+&fmc {
+     status = "okay";
+
+     flash at 0 {
+             status = "okay";
+             label = "pnor";
+             m25p,fast-read;
+#include "openbmc-flash-layout.dtsi"
+     };
+};
+
+&spi1 {
+     status = "okay";
+
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_spi1_default>;
+
+     flash at 0 {
+             status = "okay";
+             label = "pnor";
+             m25p,fast-read;
      };
 };

hmm, the fmc and spi1 bindings were already added in commit 1142aea9ff9d.

quoted

@@ -38,6 +101,7 @@
              status = "okay";
              m25p,fast-read;
              label = "bmc";
+#include "openbmc-flash-layout.dtsi"

This looks like an extra "fmc" node ?

You're right. It still built and booted too. Good catch.

Cheers,

Joel