Thread (11 messages) 11 messages, 3 authors, 2017-12-18

[PATCH v7 1/6] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor

From: Appana Durga Kedareswara Rao <hidden>
Date: 2017-12-18 06:54:03
Also in: dmaengine, lkml

Hi,

	Thanks for the review...

<Snip>
On Thu, Dec 07, 2017 at 10:51:02AM +0530, Kedareswara rao Appana wrote:
quoted
@@ -2029,6 +2006,7 @@ static int xilinx_dma_terminate_all(struct
dma_chan *dchan)

 	/* Remove and free all of the descriptors in the lists */
 	xilinx_dma_free_descriptors(chan);
+	chan->idle = true;

 	if (chan->cyclic) {
 		reg = dma_ctrl_read(chan, XILINX_DMA_REG_DMACR); @@ -
2344,6
quoted
+2322,12 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device
*xdev,
quoted
 	chan->has_sg = xdev->has_sg;
 	chan->desc_pendingcount = 0x0;
 	chan->ext_addr = xdev->ext_addr;
+	/* This variable enusres that descripotrs are not
			      ^^^^^^^^^^

typo
Since this patch got applied 
Will take care of this next time on wards... 
Thanks for the review... 

Regards,
Kedar.
--
~Vinod
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help