Thread (16 messages) 16 messages, 4 authors, 2017-12-19

[PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

From: sakari.ailus@iki.fi (Sakari Ailus)
Date: 2017-12-18 06:24:03
Also in: linux-devicetree, linux-media, lkml

Hi Wenyou,

Wenyou Yang wrote:
...
+static int ov7740_start_streaming(struct ov7740 *ov7740)
+{
+	int ret;
+
+	if (ov7740->fmt) {
+		ret = regmap_multi_reg_write(ov7740->regmap,
+					     ov7740->fmt->regs,
+					     ov7740->fmt->reg_num);
+		if (ret)
+			return ret;
+	}
+
+	if (ov7740->frmsize) {
+		ret = regmap_multi_reg_write(ov7740->regmap,
+					     ov7740->frmsize->regs,
+					     ov7740->frmsize->reg_num);
+		if (ret)
+			return ret;
+	}
+
+	return __v4l2_ctrl_handler_setup(ov7740->subdev.ctrl_handler);
I believe you're still setting the controls after starting streaming.

-- 
Sakari Ailus
sakari.ailus at iki.fi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help