On 12/14/17 4:30 AM, Lorenzo Pieralisi wrote:

quoted

I didn't want to put any ACPI code in amba-pl011.c, so putting it in spcr.c
made the most sense.  I agree the global variable is ugly.  If you have a
better idea, I'm all ears.

I told you my idea. It could have been made easier by reusing the
ACPI_DECLARE_PROBE_ENTRY() mechanism.

Sorry, I don't mean to be difficult, but when did you tell *me* this 
idea of yours?  I don't see any email from you to me that mentions 
ACPI_DECLARE_PROBE_ENTRY().  I've never even heard of that macro before. 
  Please note that I'm not the original author of this code.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.