Thread (15 messages) 15 messages, 5 authors, 2017-12-11

[PATCH 2/2] acpi, x86: Use SPCR table for earlycon on x86

From: Timur Tabi <hidden>
Date: 2017-12-07 18:46:48
Also in: linux-acpi, linux-pm, linux-serial, lkml

On Thu, Dec 7, 2017 at 11:29 AM, Prarit Bhargava [off-list ref] wrote:
quoted hunk ↗ jump to hunk
-int __init acpi_parse_spcr(bool earlycon)
+int __init acpi_parse_spcr(bool earlycon, bool enable_console)
 {
        static char opts[ACPI_SPCR_OPTS_SIZE];
        static char uart[ACPI_SPCR_BUF_SIZE];
@@ -113,7 +113,8 @@ int __init acpi_parse_spcr(bool earlycon)
        if (earlycon)
                setup_earlycon(opts);

-       err = add_preferred_console(uart, 0, opts + strlen(uart) + 1);
+       if (enable_console)
+               err = add_preferred_console(uart, 0, opts + strlen(uart) + 1);
So if earlycon==true but enable_console==false, then you parse SPCR
and use it for the early console, but not the primary console?  I'm
not sure what that gives you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help