Hi Chen-Yu,

On 07/12/2017 09:54, Chen-Yu Tsai wrote:

On Thu, Dec 7, 2017 at 4:51 PM, Quentin Schulz
[off-list ref] wrote:

quoted

Hi Maxime,

On 05/12/2017 09:08, Maxime Ripard wrote:

quoted

On Mon, Dec 04, 2017 at 03:12:49PM +0100, Quentin Schulz wrote:

quoted

This makes the axp20x_adc driver probe with platform device id
"axp813-adc".

Signed-off-by: Quentin Schulz <redacted>
---
 drivers/mfd/axp20x.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 2468b43..42e54d1 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c

@@ -878,7 +878,9 @@ static struct mfd_cell axp813_cells[] = {
             .resources              = axp803_pek_resources,
     }, {
             .name                   = "axp20x-regulator",
-    }
+    }, {
+            .name                   = "axp813-adc",
+    },

Any particular reason you're not adding it to the DT?

No, no particular reason. It's just the way it is currently for AXP209
and AXP22x so did the same for AXP813.

I'll add DT "support" in next version for all AXPs supported by this
driver. Or is it worthy of a small separate patch series?

IIRC there's no DT support because there's no need to reference
it in the device tree.

No current need but that does not mean there won't be a need later for
drivers to map IIO channels from the ADC driver (i.e. some components
wired to GPIOs of the PMIC for example).

Quentin
-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com