[PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root

On 11/30/2017 04:45 PM, Geert Uytterhoeven wrote:

quoted

quoted

quoted

quoted

Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
as per:
* commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
* commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")

Also set ignore_loglevel rw as boot args as is the case for the boards
for the boards for other Renesas ARM/ARM64 based SoCs.

s/for the boards//

quoted

Signed-off-by: Simon Horman <redacted>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

Sergei has pointed out that bootargs has seems to have effect on ARM64
kernels. So I think this patch should be withdrawn and we should consider
removing bootargs from those ARM64 boards where it is present.

I don't think this is true.

I just added a argument to bootargs to salvator-common.dtsi for some
hack testing and it took effect. Tested on-top of latest renesas-drivers
and H3 ES2.0.

quoted

quoted

quoted

DIFF <<<

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 7b30044a55367d35..4cb4b44f8be42cb4 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi

@@ -42,7 +42,7 @@
         };

         chosen {
-               bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
+               bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1";
                 stdout-path = "serial0:115200n8";
         };

quoted

quoted

quoted

END DIFF <<<

# cat /sys/firmware/devicetree/base/chosen/bootargs
ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1

And the module parameter had the expected effect on the adv7482x driver.
Is there another issue here which I'm missing?

1. It may depend on the U-Boot version

    It probably does! My U-Boot clearly copies its "bootargs" env. variable 
into DT's "/chosen/bootargs" prop.

2. Anyone playing with CONFIG_CMDLINE and CONFIG_CMDLINE_FORCE?

    Not me (before now). Tried it now and it works as expected.

Gr{oetje,eeting}s,

                         Geert

MBR, Sergei