On Thu, Nov 23, 2017 at 06:35:10PM +0200, Baruch Siach wrote:

Hi Russell,

On Thu, Nov 23, 2017 at 03:24:17PM +0000, Russell King - ARM Linux wrote:

quoted

On Wed, Nov 22, 2017 at 04:42:04PM +0200, Baruch Siach wrote:

quoted

The AP806 component is integrated in the Armada 8k and 7k lines of processors.

<cut>

quoted

quoted

+	mdelay(10);

Do you really need to make the CPU busy-wait for 10ms here?  This
looks like it's called from a schedulable context, so won't msleep()
do?

Yes, that is schedulable context.

msleep() should be fine as well. I just mindlessly copied this code from the 
vendor kernel. I'll change that in the next iteration.

Yes please, send next version without CPU spinning delays.

Thanks for reviewing,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -