On 09/11/17 13:50, Jan L?bbe wrote:

On Tue, 2017-11-07 at 22:38 +0200, Tero Kristo wrote:

quoted

+       if (edac_mc_add_mc(mci)) {
+               pr_err("%s: Failed to register mci.\n", __func__);
+               return -ENOMEM;

This leaks the allocated mci structure in the error case.

quoted

+       }
+
+       /* add EMIF ECC error handler */
+       error_irq = platform_get_irq(pdev, 0);
+       if (!error_irq) {
+               dev_err(dev, "DDR3 EDAC irq number not defined\n");
+               return ret;

This leaves the mc registered in the error case.

I am too much used to devm_alloc nowadays I guess... I'll fix these for 
v2 and maybe re-arrange the irq alloc with rest of the code.

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki