Fwd: [PATCH 2/4] gpiolib: add bitmask for valid GPIO lines

From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
Date: 2017-11-15 11:40:14
Also in: linux-arm-msm, linux-gpio

On Wed, 2017-11-15 at 11:58 +0530, Varadarajan Narayanan wrote:

quoted

+	if (gpiochip->irq_need_valid_mask) {
+		gpiochip->irq_valid_mask =
+			kcalloc(BITS_TO_LONGS(gpiochip->ngpio),
+				sizeof(long), GFP_KERNEL);

Since 'irq_valid_mask' is getting filled below wouldn't a kmalloc
suffice?

I suppose you meant kmalloc_array.
Anyway, it's a separate change if you wish, because Timur didn't change
the original approach here.

quoted

+		if (!gpiochip->irq_valid_mask)
+			return -ENOMEM;

quoted

+		/* Assume by default all GPIOs are valid */
+		bitmap_fill(gpiochip->irq_valid_mask, gpiochip-

quoted

ngpio);

+	}

quoted

+	if (gpiochip->line_need_valid_mask) {
+		gpiochip->line_valid_mask =
+			kcalloc(BITS_TO_LONGS(gpiochip->ngpio),
+				sizeof(long), GFP_KERNEL);

Since 'line_valid_mask' is getting filled below wouldn't a kmalloc
suffice?

This one just mimics previous, so, see above.

-- 
Andy Shevchenko [off-list ref]
Intel Finland Oy