[RFCv2 PATCH 09/36] iommu/fault: Allow blocking fault handlers
From: Yisheng Xie <hidden>
Date: 2017-11-29 06:15:58
Also in:
linux-acpi, linux-devicetree, linux-iommu, linux-pci
Possibly related (same subject, not in this thread)
- 2017-11-30 · Re: [RFCv2 PATCH 09/36] iommu/fault: Allow blocking fault handlers · Yisheng Xie <hidden>
- 2017-11-29 · Re: [RFCv2 PATCH 09/36] iommu/fault: Allow blocking fault handlers · Jean-Philippe Brucker <hidden>
- 2017-10-06 · [RFCv2 PATCH 09/36] iommu/fault: Allow blocking fault handlers · Jean-Philippe Brucker <hidden>
Hi Jean, On 2017/10/6 21:31, Jean-Philippe Brucker wrote:
- if (domain->ext_handler) {
+ if (domain->handler_flags & IOMMU_FAULT_HANDLER_ATOMIC) {
+ fault->flags |= IOMMU_FAULT_ATOMIC;Why remove the condition of domain->ext_handler? should it be much better like: if ((domain->handler_flags & IOMMU_FAULT_HANDLER_ATOMIC) && domain->ext_handler) If domain->ext_handler is NULL, and (domain->handler_flags & IOMMU_FAULT_HANDLER_ATOMIC) is true. It will oops, right?
ret = domain->ext_handler(domain, dev, fault, domain->handler_token);
Thanks Yisheng Xie