[PATCH 1/2] arm64: dts: orange-pi-zero-plus2: fix sdcard detect

On Tue, Nov 7, 2017 at 1:12 PM, Jagan Teki [off-list ref] wrote:

On Mon, Nov 6, 2017 at 9:43 PM, Sergey Matyukevich [off-list ref] wrote:

quoted

Hello Maxime,

quoted

quoted

quoted

quoted

The sdcard detect pin on orange-pi-zero-plus2 is pulled up.
Fix cd-gpio description to enable sdcard detect.

Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
index b6b7a561df8c..a42fd79a62a3 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts

@@ -71,7 +71,7 @@
        pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
        vmmc-supply = <&reg_vcc3v3>;
        bus-width = <4>;
-       cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
+       cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;

Was able to detect and do mount with existing dts

Did you try to boot from sdcard ? I am not able to boot my board from
sd-card without this change. As I mentioned earlier in my email
to buildroot mailing list, with mmc debug enabled I see that mmc
tries to init sd-card when I remove it from the slot.

Maybe there is a minor differences between h/w versions or batches ?
What is you board version ? I tested on board v1.0.

Looking at the schematics, it definitely looks like it's active low.

Is it ok to merge it then ? Or using 'cd-inverted' property
is the preferable option ?

W/o any change mainline works unstable for me, it wasn't booting
at-all[1] did you find the same?

Even tried with active LOW and cd-inverted.

[1] https://paste.ubuntu.com/25909064/

Look like something broken for H5 and A64 between v4.14-rc8 to latest

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.