[PATCH 3/6 v2] mmc: sdhci-acpi: Handle return value of platform_get_irq
From: Arvind Yadav <hidden>
Date: 2017-11-18 09:35:26
Also in:
linux-amlogic, linux-mmc, lkml
Subsystem:
multimedia card (mmc), secure digital (sd) and sdio subsystem, secure digital host controller interface (sdhci) driver, the rest · Maintainers:
Ulf Hansson, Adrian Hunter, Linus Torvalds
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <redacted>
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
drivers/mmc/host/sdhci-acpi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index b988997..dd8129e 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c@@ -566,6 +566,10 @@ static int sdhci_acpi_probe(struct platform_device *pdev) host->hw_name = "ACPI"; host->ops = &sdhci_acpi_ops_dflt; host->irq = platform_get_irq(pdev, 0); + if (host->irq <= 0) { + err = host->irq; + goto err_free; + } host->ioaddr = devm_ioremap_nocache(dev, iomem->start, resource_size(iomem));
--
2.7.4