Thread (1 message) 1 message, 1 author, 2017-10-15
DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

[PATCH v2 2/2] ARM: dts: imx6q-cm-fx6: Use the 'vpcie-supply' property

From: Christopher Spinrath <hidden>
Date: 2017-10-15 21:03:38

On 10/15/2017 10:53 PM, Fabio Estevam wrote:
From: Fabio Estevam <redacted>

According to Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt,
the property for specifying the PCIe regulator is 'vpcie-supply', so
use the correct one.

Also fix the polarity of GPIO2_24 so that the regulator can operate
correctly.

Cc: Christopher Spinrath <redacted>
Signed-off-by: Fabio Estevam <redacted>
Tested-by: Christopher Spinrath <redacted>

Thanks!
Christopher
quoted hunk
---
Changes since v1:
- Also fix the GPIO2_24 polarity. (Christopher)

 arch/arm/boot/dts/imx6q-cm-fx6.dts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-cm-fx6.dts b/arch/arm/boot/dts/imx6q-cm-fx6.dts
index fe6ab0a..bc7587c 100644
--- a/arch/arm/boot/dts/imx6q-cm-fx6.dts
+++ b/arch/arm/boot/dts/imx6q-cm-fx6.dts
@@ -77,8 +77,7 @@
 		regulator-name = "regulator-pcie-power-on-gpio";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio2 24 GPIO_ACTIVE_HIGH>;
-		enable-active-high;
+		gpio = <&gpio2 24 GPIO_ACTIVE_LOW>;
 	};
 
 	reg_usb_h1_vbus: usb_h1_vbus {
@@ -362,7 +361,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio1 26 GPIO_ACTIVE_LOW>;
-	vdd-supply = <&reg_pcie_power_on_gpio>;
+	vpcie-supply = <&reg_pcie_power_on_gpio>;
 	status = "okay";
 };
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help