[PATCH 04/11] watchdog: ftwdt010: Add clock support
From: joel@jms.id.au (Joel Stanley)
Date: 2017-10-12 03:39:50
Also in:
linux-watchdog
On Wed, Oct 11, 2017 at 4:06 AM, Linus Walleij [off-list ref] wrote:
So need info from Joel Stanley here: On Tue, Oct 10, 2017 at 9:51 PM, Linus Walleij [off-list ref] wrote:quoted
On Sun, Aug 27, 2017 at 7:06 PM, Guenter Roeck [off-list ref] wrote:quoted
On Thu, Aug 24, 2017 at 10:32:22PM +0200, Linus Walleij wrote:quoted
On Mon, Aug 14, 2017 at 6:05 PM, Guenter Roeck [off-list ref] wrote:quoted
quoted
If I understand your comment below correctly, the driver won't work without clock subsystem because the clock frequency would in that case be 0. Why not catch that situation here, or even better make the driver depends on the clock subsystem ?OK fair enough I can do that. I think Aspeed is merging its clock driver this kernel cycle so all variant SoCs actually have clocks.So when I later in the patch series convert Aspeed to use this driver we get a problem because Joel is currently working on the clock driver for Aspeed and it's not ready for merge yet as it looks. I can of course wait with the Aspeed conversion to use the common driver. Also I can slap in a fixed-rate clock in the device tree @1 MHz. But that is cheating.
All of our clocks in the device tree are cheating at the moment :)
So I guess I rest the Aspeed conversion. Joel: does your clock patch set cover the 1MHz used by the watchdog EXTCLK?
It doesn't; none of the documentation I have describes where it comes from. I will add something in the next iteration. Cheers, Joel