Thread (1 message) 1 message, 1 author, 2017-10-10
DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

[PATCH v4 1/7] KVM: arm/arm64: Remove redundant preemptible checks

From: Marc Zyngier <hidden>
Date: 2017-10-10 10:06:10
Also in: kvm, kvmarm

On Fri, Sep 15 2017 at  3:19:48 pm BST, Christoffer Dall [off-list ref] wrote:
quoted hunk
From: Christoffer Dall <redacted>

The __this_cpu_read() and __this_cpu_write() functions already implement
checks for the required preemption levels when using
CONFIG_DEBUG_PREEMPT which gives you nice error messages and such.
Therefore there is no need to explicitly check this using a BUG_ON() in
the code (which we don't do for other uses of per cpu variables either).

Signed-off-by: Christoffer Dall <redacted>
---
 virt/kvm/arm/arm.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
index a39a1e1..04313a2 100644
--- a/virt/kvm/arm/arm.c
+++ b/virt/kvm/arm/arm.c
@@ -69,7 +69,6 @@ static DEFINE_PER_CPU(unsigned char, kvm_arm_hardware_enabled);
 
 static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu)
 {
-	BUG_ON(preemptible());
 	__this_cpu_write(kvm_arm_running_vcpu, vcpu);
 }
 
@@ -79,7 +78,6 @@ static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu)
  */
 struct kvm_vcpu *kvm_arm_get_running_vcpu(void)
 {
-	BUG_ON(preemptible());
 	return __this_cpu_read(kvm_arm_running_vcpu);
 }
Acked-by: Marc Zyngier <redacted>

	M.
-- 
Jazz is not dead, it just smell funny.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help