Thread (1 message) 1 message, 1 author, 2017-10-26

[PATCH v3 2/2] phy: add combo phy driver for HiSilicon STB SoCs

From: shawnguo@kernel.org (Shawn Guo)
Date: 2017-10-26 14:31:14
Also in: linux-devicetree

On Wed, Oct 25, 2017 at 04:44:09PM +0800, Shawn Guo wrote:
+static int histb_combphy_init(struct phy *phy)
+{
+	struct histb_combphy_priv *priv = phy_get_drvdata(phy);
+	u32 val;
+	int ret;
+
+	/* PHY0 doesn't support mode setting */
+	if (priv->phy_id != 0) {
With a bit more think on this, I admit it might not scale for future
SoCs which could reasonably support mode select for combphy0.  So
instead of hard checking device id, I will repost with a new property
added for this. 

Shawn
+		ret = histb_combphy_set_mode(priv);
+		if (ret)
+			return ret;
+	}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help