Thread (1 message) 1 message, 1 author, 2017-10-23

[PATCH v3 6/6] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property

From: shawnguo@kernel.org (Shawn Guo)
Date: 2017-10-23 00:38:10
Also in: linux-devicetree

On Fri, Oct 20, 2017 at 01:48:27PM -0200, Marco Franchi wrote:
The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property

Fix this warning by adding reg property from such node.

Signed-off-by: Marco Franchi <redacted>
I'm not sure if you tested the change, but I'm seeing the following
warning.

Warning (reg_format): "reg" property in
/soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length
(4 bytes) (#address-cells == 2, #size-cells == 1)

Shawn
quoted hunk
---
Changes since v2:
-change message log
-add reg property
 arch/arm/boot/dts/imx53-tx53.dtsi | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
index 76e7186..61ecd13 100644
--- a/arch/arm/boot/dts/imx53-tx53.dtsi
+++ b/arch/arm/boot/dts/imx53-tx53.dtsi
@@ -226,6 +226,7 @@
 	status = "okay";
 
 	phy0: ethernet-phy at 0 {
+		reg = <0>;
 		interrupts-extended = <&gpio2 4 IRQ_TYPE_EDGE_FALLING>;
 		device_type = "ethernet-phy";
 	};
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help