Thread (7 messages) 7 messages, 4 authors, 2017-12-16

[PATCH] kbuild: fix dependency of dtbs targets

From: Masahiro Yamada <hidden>
Date: 2017-10-25 05:41:42
Also in: linux-kbuild, lkml

Hi.


2017-10-10 0:05 GMT+09:00 Russell King - ARM Linux [off-list ref]:
On Wed, Oct 04, 2017 at 01:27:20PM +0900, Masahiro Yamada wrote:
quoted
The target "dtbs" should depend on "scripts" because it needs to
build dtc.  The "prepare" target is unneeded here.
Looks fine for ARM, as the only thing the dtbs should depend on is
the kernel configuration (to decide which to build) and DT tooling.

Acked-by: Russell King <redacted>

--

I found a potential issue on this
because the default DTB install path depends on $(KERNELRELEASE).


In top-level Makefile:
export INSTALL_DTBS_PATH ?= $(INSTALL_PATH)/dtbs/$(KERNELRELEASE)


The include/config/kernel.release is created by "prepare3" target.

If the dependency on "parepare" is removed,
it is possible to run "make dtbs" and "make dtbs_install"
without creating include/config/kernel.release.

So, the $(KERNELRELEASE) could be empty when installing DTB.


Maybe, drop this patch, or reduce the dependency to "parepare3"?







-- 
Best Regards
Masahiro Yamada
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help