Thread (58 messages) 58 messages, 5 authors, 2017-10-24

[PATCH 05/23] drm/sun4i: tcon: Don't rely on encoders to enable the TCON

From: Chen-Yu Tsai <hidden>
Date: 2017-10-17 09:29:12
Also in: dri-devel, linux-clk, lkml

On Tue, Oct 17, 2017 at 5:06 PM, Maxime Ripard
[off-list ref] wrote:
So far, we've required all the TCON-connected encoders to call the TCON
enable and disable functions.

This was made this way because in the RGB/LVDS case, the TCON is the CRTC
and the encoder. However, in all the other cases (HDMI, TV, DSI, etc.), we
have another encoder down the road that needs to be programmed.

We also needed to know which channel the encoder is connected to, which is
encoder-specific.

The CRTC's enable and disable callbacks can work just fine for our use
case, and we can get the channel to use just by looking at the type of
encoder, since that is fixed. Implement those callbacks, which will
remove some of the encoder boilerplate.

Signed-off-by: Maxime Ripard <redacted>
Reviewed-by: Chen-Yu Tsai <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help