Thread (26 messages) 26 messages, 4 authors, 2017-10-14

[PATCH v2 03/13] mmc: dt-bindings: make compatible explicit

From: robh@kernel.org (Rob Herring)
Date: 2017-10-13 20:09:49
Also in: linux-devicetree, linux-mediatek, linux-mmc, lkml

On Tue, Oct 10, 2017 at 09:19:14AM +0200, Ulf Hansson wrote:
On 10 October 2017 at 03:37, Chaotian Jing [off-list ref] wrote:
quoted
On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote:
quoted
On 10/09/2017 01:35 PM, Chaotian Jing wrote:
quoted
the driver has updated to have an explicit compatible, so update
binding file according to the driver change.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
  Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
index 3e0a97c..2bb585b 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
@@ -8,8 +8,8 @@ and the properties used by the msdc driver.

  Required properties:
  - compatible: value should be either of the following.
-   "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
-   "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173
+   "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
+   "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
You can merge this with patch 1.
OK, will merge it in next patch.
No, please don't!

I would like DT documentation changes to be posted in separate
patches. Moreover, those should be before driver changes, when you
order the changes in your series.

In this way, the bindings can be reviewed and acked separately, which
makes it more convenient.
Yes. Also, it is step 2 in 
Documentation/devicetree/bindings/submitting-patches.txt.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help