[PATCH 5/9] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports

Hi Andrew,

On Mon, Sep 18, 2017 at 03:04:37PM +0200, Andrew Lunn wrote:

On Mon, Sep 18, 2017 at 11:50:12AM +0300, Baruch Siach wrote:

quoted

On Mon, Sep 18, 2017 at 09:58:10AM +0200, Antoine Tenart wrote:

quoted

This patch adds comphy phandles to the Ethernet ports in the mcbin
device tree. The comphy is used to configure the serdes PHYs used by
these ports.

Signed-off-by: Antoine Tenart <redacted>
---
 arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
index acf5c7d16d79..9a3b4a1fd445 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts

@@ -223,6 +223,7 @@
 &cpm_eth0 {
 	status = "okay";
 	phy = <&phy0>;
+	phys = <&cpm_comphy4 0>;
 	phy-mode = "10gbase-kr";

Since the 'phys' generic PHY property is unrelated to the 'phy*' Ethernet PHY 
properties that surround it, its location might be confusing. I think it 
should appear below those two other properties like you did below ...

Yes, i agree. It is confusing enough as it is, so we should not make
it worse.

I even wonder if it is worth doing some renaming?

  	phy = <&ethernet_phy0>;
  	phy-mode = "10gbase-kr";
 	phys = <&cpm_generic_comphy4 0>;

We could also add an extra comment without renaming the comphy node, something
like:

	/* Network PHY */
	phy = <&ethernet_phy0>;
	phy-mode = "10gbase-kr";
	/* Generic PHY, providing serdes lanes */
	phys = <&cpm_comphy4 0>;

Thanks,
Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170918/0161fae3/attachment.sig>