Thread (27 messages) 27 messages, 5 authors, 2017-10-09

[PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

From: clabbe.montjoie@gmail.com (Corentin Labbe)
Date: 2017-09-28 07:37:19
Also in: linux-devicetree, lkml, netdev

On Wed, Sep 27, 2017 at 04:02:10PM +0200, Andrew Lunn wrote:
Hi Corentin
quoted
+Required properties for the mdio-mux node:
+  - compatible = "mdio-mux"
This is too generic. Please add a more specific compatible for this
particular mux. You can keep "mdio-mux", since that is what the MDIO
subsystem will look for.
I will add allwinner,sun8i-h3-mdio-mux
quoted
+Required properties of the integrated phy node:
 - clocks: a phandle to the reference clock for the EPHY
 - resets: a phandle to the reset control for the EPHY
+- phy-is-integrated
So the last thing you said is that the mux is not the problem
here. Something else is locking up. Did you discover what?

I really would like phy-is-integrated to go away.
I have found the problem: by enabling ephy clk/reset the timeout does not occur anymore.
So we could remove phy-is-integrated by:
Moving internal phy clk/reset handling in mdio_mux_syscon_switch_fn()
But this means:
- getting internalphy node always by manually get internal_mdio/internal_phy (and not by the given phyhandle)
- doing some unnecessary tasks (enable/scan/disable) when external_phy is needed

Regards
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help