Thread (18 messages) 18 messages, 5 authors, 2017-09-26

[PATCH v4 2/4] thermal: add brcmstb AVS TMON driver

From: f.fainelli@gmail.com (Florian Fainelli)
Date: 2017-09-24 21:11:35
Also in: linux-devicetree, linux-pm, lkml

Le 08/14/17 ? 23:48, Zhang Rui a ?crit?:
On Tue, 2017-08-15 at 08:42 +0200, Rafa? Mi?ecki wrote:
quoted
On 2017-08-15 08:08, Zhang Rui wrote:
quoted
quoted
diff --git a/drivers/thermal/broadcom/Kconfig
b/drivers/thermal/broadcom/Kconfig
index 42c098e..c106a15 100644
--- a/drivers/thermal/broadcom/Kconfig
+++ b/drivers/thermal/broadcom/Kconfig
@@ -6,6 +6,13 @@ config BCM2835_THERMAL
?	help
?	??Support for thermal sensors on Broadcom bcm2835 SoCs.
?
+config BRCMSTB_THERMAL
+	tristate "Broadcom STB AVS TMON thermal driver"
+	depends on ARCH_BRCMSTB || COMPILE_TEST
+	help
+	??Enable this driver if you have a Broadcom STB SoC and
would like
+	??thermal framework support.
+
I don't understand why I got the following checkpatch warning

WARNING: please write a paragraph that describes the config symbol
fully
#73: FILE: drivers/thermal/broadcom/Kconfig:9:
+config BRCMSTB_THERMAL

I didn't see this for other Kconfig changes.
It's because your help message is only 2 lines long (instead of 3).

Some (many?) maintainers aren't pedantic about that, a common sense?
should
be applied ;)
thanks for explaining.
Patch 1 and 2 queued for next merge window.
Humm, I don't see this driver in your latest 4.14 pull request to Linus,
so what happened here exactly? Can we expect this driver to be submitted
for 4.14 or we just happened to have missed this window now?
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help