[PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf
From: Arvind Yadav <hidden>
Date: 2017-09-20 07:14:14
Also in:
linux-gpio, lkml
Subsystem:
broadcom brcmstb gpio driver, gpio subsystem, the rest · Maintainers:
Doug Berger, Florian Fainelli, Linus Walleij, Bartosz Golaszewski, Linus Torvalds
devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <redacted> --- drivers/gpio/gpio-brcmstb.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index dd0308c..1227d6e 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c@@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev) gc->of_node = np; gc->owner = THIS_MODULE; gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node); + if (!gc->label) + goto fail; + gc->base = gpio_base; gc->of_gpio_n_cells = 2; gc->of_xlate = brcmstb_gpio_of_xlate;
--
1.9.1