[PATCH v8 05/20] crypto: marvell/cesa: remove redundant backlog checks on EBUSY
flat view
STALE3285d
REVIEWED: 1 (0M)
From: gilad@benyossef.com (Gilad Ben-Yossef)
Date: 2017-09-05 12:40:45
Also in:
dm-devel, keyrings, linux-crypto, linux-fscrypt, linux-security-module, lkml, netdev
Subsystem:
crypto api, marvell crypto driver, the rest · Maintainers:
Herbert Xu, "David S. Miller", Srujana Challa, Bharat Bhushan, Linus Torvalds
Revision v8 of 19 in this series; 1 review trailer.
Revisions (19)
- v3 [diff vs current]
- v3 [diff vs current]
- v4 [diff vs current]
- v4 [diff vs current]
- v4 [diff vs current]
- v5 [diff vs current]
- v5 [diff vs current]
- v5 [diff vs current]
- v6 [diff vs current]
- v6 [diff vs current]
- v6 [diff vs current]
- v7 [diff vs current]
- v7 [diff vs current]
- v7 [diff vs current]
- v8
- v8
- v8 current
- v9 [diff vs current]
- v10 [diff vs current]
Now that -EBUSY return code only indicates backlog queueing we can safely remove the now redundant check for the CRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Acked-by: Boris Brezillon <redacted> --- drivers/crypto/marvell/cesa.c | 3 +-- drivers/crypto/marvell/cesa.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/marvell/cesa.c b/drivers/crypto/marvell/cesa.c
index 6e7a5c7..0c3909d 100644
--- a/drivers/crypto/marvell/cesa.c
+++ b/drivers/crypto/marvell/cesa.c@@ -183,8 +183,7 @@ int mv_cesa_queue_req(struct crypto_async_request *req, spin_lock_bh(&engine->lock); ret = crypto_enqueue_request(&engine->queue, req); if ((mv_cesa_req_get_type(creq) == CESA_DMA_REQ) && - (ret == -EINPROGRESS || - (ret == -EBUSY && req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG))) + (ret == -EINPROGRESS || ret == -EBUSY)) mv_cesa_tdma_chain(engine, creq); spin_unlock_bh(&engine->lock);
diff --git a/drivers/crypto/marvell/cesa.h b/drivers/crypto/marvell/cesa.h
index b7872f6..63c8457 100644
--- a/drivers/crypto/marvell/cesa.h
+++ b/drivers/crypto/marvell/cesa.h@@ -763,7 +763,7 @@ static inline int mv_cesa_req_needs_cleanup(struct crypto_async_request *req, * the backlog and will be processed later. There's no need to * clean it up. */ - if (ret == -EBUSY && req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG) + if (ret == -EBUSY) return false; /* Request wasn't queued, we need to clean it up */
--
2.1.4