On Tue, Sep 5, 2017 at 2:23 PM, Harsh Jain [off-list ref] wrote:
On Sun, Sep 3, 2017 at 11:47 AM, Gilad Ben-Yossef [off-list ref] wrote:
quoted
On Thu, Aug 31, 2017 at 3:31 PM, Harsh Jain [off-list ref] wrote:
quoted
HI Gilad,
I think we need an update in ESP also. Now EBUSY return means driver
has accepted, Packet should not be dropped in
esp_output_tail() function.
Good catch. You are right and the same holds true for ah_output() in ah4.c.
But I do wonder, the code there now treats -EBUSY as a special case
and returns NET_XMIT_DROP
but if an AEAD or AHASH transformation return some other error, like
-ENOMEM or -EINVAL shouldn't
we return NET_XMIT_DROP in that case too?
I think we should not, XMIT_DROP implies drop current packet only,
later on when device is recovered from busy state, Upper layer
protocol(TCP) will re-transmit the packet. It helps in flow control.
quoted
I see. Makes sense.
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru