[PATCH 02/30] ARM: assembler: introduce adr_l, ldr_l and str_l macros
From: linux@armlinux.org.uk (Russell King - ARM Linux)
Date: 2017-08-14 16:42:27
On Mon, Aug 14, 2017 at 05:22:39PM +0100, Ard Biesheuvel wrote:
On 14 August 2017 at 17:18, Nicolas Pitre [off-list ref] wrote:quoted
On Mon, 14 Aug 2017, Dave Martin wrote:quoted
On Mon, Aug 14, 2017 at 04:38:02PM +0100, Ard Biesheuvel wrote:quoted
That's a trick, actually, which I failed to add a comment for.Shame shame shame !quoted
quoted
We use .arm sections in the thumb2 kernel, and using these macros there would result in the wrong offset to be used. Adding the .w suffix forces an error in the assembler which even results in a fairly meaningful error message complaining about using .w in ARM code.Ewww... I think it'd be best to add a comment explaining that.Absolutely!Yeah, mea culpa. But if people have better ideas how to avoid this situation, I am all ears.
Have you tested building an ARMv7M kernel with your patches - ARMv7M is Thumb only, so can't contain any ARM code. If not, please try mps2_defconfig. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up