From: Simon Horman <hidden> Date: 2017-08-08 08:39:19
Use newly added R-Car GPIO Gen1 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in DT of r8a7778 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
---
arch/arm/boot/dts/r8a7778.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
From: Simon Horman <hidden> Date: 2017-08-08 08:39:20
Use newly added R-Car GPIO Gen1 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in DT of r8a7779 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
---
arch/arm/boot/dts/r8a7779.dtsi | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
From: Simon Horman <hidden> Date: 2017-08-08 08:39:21
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7743 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
---
arch/arm/boot/dts/r8a7743.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
From: Simon Horman <hidden> Date: 2017-08-08 08:39:22
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7790 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
---
arch/arm/boot/dts/r8a7790.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
From: Simon Horman <hidden> Date: 2017-08-08 08:39:23
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7791 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
---
arch/arm/boot/dts/r8a7791.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
From: Simon Horman <hidden> Date: 2017-08-08 08:39:24
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7792 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
---
arch/arm/boot/dts/r8a7792.dtsi | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
From: Simon Horman <hidden> Date: 2017-08-08 08:39:25
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7793 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
---
arch/arm/boot/dts/r8a7793.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
From: Simon Horman <hidden> Date: 2017-08-08 08:39:26
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7794 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
---
arch/arm/boot/dts/r8a7794.dtsi | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
From: Simon Horman <hidden> Date: 2017-08-08 08:39:27
Use newly added R-Car GPIO Gen3 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7795 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
From: Simon Horman <hidden> Date: 2017-08-08 08:39:28
Use newly added R-Car GPIO Gen3 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7796 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
---
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
Hi Simon,
On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman [off-list ref] wrote:
Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place
of now deprecated non-generation specific R-Car GPIO fallback compat string
in the DT of Renesas ARM and arm64 based SoCs.
This should have no run-time effect as the driver matches against the
per-SoC compat string before considering the fallback compat string.
Thanks for your efforts.I have no issue with your series (apart from
the GPIO and SATA mistake), but at the same time I believe the GPIO
hardware itself is backwards compatible between various generations.
In the nitpick department I would like to point out that the level of
hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is
similar to say good old uarts like 8250 and 16450 hardware. Basically
a couple of registers were added to the hardware in a
backwards-compatible way if I recall correctly.
So if we are going to use "compatible" to point out if hardware is
compatible or not then I would do this instead:
On Tue, Aug 08, 2017 at 07:29:28PM +0900, Magnus Damm wrote:
Hi Simon,
On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman [off-list ref] wrote:
quoted
Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place
of now deprecated non-generation specific R-Car GPIO fallback compat string
in the DT of Renesas ARM and arm64 based SoCs.
This should have no run-time effect as the driver matches against the
per-SoC compat string before considering the fallback compat string.
Thanks for your efforts.I have no issue with your series (apart from
the GPIO and SATA mistake), but at the same time I believe the GPIO
hardware itself is backwards compatible between various generations.
In the nitpick department I would like to point out that the level of
hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is
similar to say good old uarts like 8250 and 16450 hardware. Basically
a couple of registers were added to the hardware in a
backwards-compatible way if I recall correctly.
So if we are going to use "compatible" to point out if hardware is
compatible or not then I would do this instead:
Thanks for your feedback.
When the generation specific compat strings were recently
added the renesas,gpio-rcar compat string was marked as deprecated
as I was under the understanding that it was only compatibile with gen 1 SoCs.
It now seems that was not the best thing to do and renesas,gpio-rcar should
be re-instated as being a generic fallback for all R-Car versions supported
in upstream.
Do you concur?
On Wed, Aug 09, 2017 at 09:55:26AM +0200, Simon Horman wrote:
On Tue, Aug 08, 2017 at 07:29:28PM +0900, Magnus Damm wrote:
quoted
Hi Simon,
On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman [off-list ref] wrote:
quoted
Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place
of now deprecated non-generation specific R-Car GPIO fallback compat string
in the DT of Renesas ARM and arm64 based SoCs.
This should have no run-time effect as the driver matches against the
per-SoC compat string before considering the fallback compat string.
Thanks for your efforts.I have no issue with your series (apart from
the GPIO and SATA mistake), but at the same time I believe the GPIO
hardware itself is backwards compatible between various generations.
In the nitpick department I would like to point out that the level of
hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is
similar to say good old uarts like 8250 and 16450 hardware. Basically
a couple of registers were added to the hardware in a
backwards-compatible way if I recall correctly.
So if we are going to use "compatible" to point out if hardware is
compatible or not then I would do this instead:
Thanks for your feedback.
When the generation specific compat strings were recently
added the renesas,gpio-rcar compat string was marked as deprecated
as I was under the understanding that it was only compatibile with gen 1 SoCs.
It now seems that was not the best thing to do and renesas,gpio-rcar should
be re-instated as being a generic fallback for all R-Car versions supported
in upstream.
Do you concur?
I posted a patch to un-deprecate the renesas,gpio-rcar compat string
in the bindings documentation.
[PATCH] gpio: rcar: reinstate generic compat string
Hi Simon,
On Wed, Aug 9, 2017 at 5:22 PM, Simon Horman [off-list ref] wrote:
On Wed, Aug 09, 2017 at 09:55:26AM +0200, Simon Horman wrote:
quoted
On Tue, Aug 08, 2017 at 07:29:28PM +0900, Magnus Damm wrote:
quoted
Hi Simon,
On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman [off-list ref] wrote:
quoted
Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place
of now deprecated non-generation specific R-Car GPIO fallback compat string
in the DT of Renesas ARM and arm64 based SoCs.
This should have no run-time effect as the driver matches against the
per-SoC compat string before considering the fallback compat string.
Thanks for your efforts.I have no issue with your series (apart from
the GPIO and SATA mistake), but at the same time I believe the GPIO
hardware itself is backwards compatible between various generations.
In the nitpick department I would like to point out that the level of
hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is
similar to say good old uarts like 8250 and 16450 hardware. Basically
a couple of registers were added to the hardware in a
backwards-compatible way if I recall correctly.
So if we are going to use "compatible" to point out if hardware is
compatible or not then I would do this instead:
Thanks for your feedback.
When the generation specific compat strings were recently
added the renesas,gpio-rcar compat string was marked as deprecated
as I was under the understanding that it was only compatibile with gen 1 SoCs.
It now seems that was not the best thing to do and renesas,gpio-rcar should
be re-instated as being a generic fallback for all R-Car versions supported
in upstream.
Do you concur?
I posted a patch to un-deprecate the renesas,gpio-rcar compat string
in the bindings documentation.
[PATCH] gpio: rcar: reinstate generic compat string
Thanks, this looks good to me. I would like to hear what Geert thinks as well!
Cheers,
/ magnus
On Wed, Aug 09, 2017 at 08:11:24PM +0900, Magnus Damm wrote:
Hi Simon,
On Wed, Aug 9, 2017 at 5:22 PM, Simon Horman [off-list ref] wrote:
quoted
On Wed, Aug 09, 2017 at 09:55:26AM +0200, Simon Horman wrote:
quoted
On Tue, Aug 08, 2017 at 07:29:28PM +0900, Magnus Damm wrote:
quoted
Hi Simon,
On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman [off-list ref] wrote:
quoted
Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place
of now deprecated non-generation specific R-Car GPIO fallback compat string
in the DT of Renesas ARM and arm64 based SoCs.
This should have no run-time effect as the driver matches against the
per-SoC compat string before considering the fallback compat string.
Thanks for your efforts.I have no issue with your series (apart from
the GPIO and SATA mistake), but at the same time I believe the GPIO
hardware itself is backwards compatible between various generations.
In the nitpick department I would like to point out that the level of
hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is
similar to say good old uarts like 8250 and 16450 hardware. Basically
a couple of registers were added to the hardware in a
backwards-compatible way if I recall correctly.
So if we are going to use "compatible" to point out if hardware is
compatible or not then I would do this instead:
Thanks for your feedback.
When the generation specific compat strings were recently
added the renesas,gpio-rcar compat string was marked as deprecated
as I was under the understanding that it was only compatibile with gen 1 SoCs.
It now seems that was not the best thing to do and renesas,gpio-rcar should
be re-instated as being a generic fallback for all R-Car versions supported
in upstream.
Do you concur?
I posted a patch to un-deprecate the renesas,gpio-rcar compat string
in the bindings documentation.
[PATCH] gpio: rcar: reinstate generic compat string
Thanks, this looks good to me. I would like to hear what Geert thinks as well!
Hi Simon,
On Tue, Aug 8, 2017 at 10:39 AM, Simon Horman
[off-list ref] wrote:
Use newly added R-Car GPIO Gen1 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in DT of r8a7778 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
That is not correct: the driver does not match against "renesas,gpio-r8a7778".
Hence this breaks using a new DTS and an old kernel (which we may decide not
to care about for R-Car Gen1, though).
But at least the DTS change should be postponed until commit d10bbd156926e65d
("gpio: rcar: add gen[123] fallback compatibility strings") has hit mainline.
... "renesas,rcar-gen1-gpio";
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Tue, Aug 8, 2017 at 10:39 AM, Simon Horman
[off-list ref] wrote:
Use newly added R-Car GPIO Gen1 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in DT of r8a7779 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
That is not correct: the driver does not match against "renesas,gpio-r8a7779".
Hence this breaks using a new DTS and an old kernel (which we may decide not
to care about for R-Car Gen1, though).
But at least the DTS change should be postponed until commit d10bbd156926e65d
("gpio: rcar: add gen[123] fallback compatibility strings") has hit mainline.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Tue, Aug 8, 2017 at 10:39 AM, Simon Horman
[off-list ref] wrote:
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7743 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Tue, Aug 8, 2017 at 10:39 AM, Simon Horman
[off-list ref] wrote:
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7790 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Tue, Aug 8, 2017 at 10:39 AM, Simon Horman
[off-list ref] wrote:
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7791 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Tue, Aug 8, 2017 at 10:39 AM, Simon Horman
[off-list ref] wrote:
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7792 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Tue, Aug 8, 2017 at 10:39 AM, Simon Horman
[off-list ref] wrote:
Use newly added R-Car GPIO Gen2 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7793 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Tue, Aug 8, 2017 at 10:39 AM, Simon Horman
[off-list ref] wrote:
Use newly added R-Car GPIO Gen3 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7795 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Tue, Aug 8, 2017 at 10:39 AM, Simon Horman
[off-list ref] wrote:
Use newly added R-Car GPIO Gen3 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in the DT of the r8a7796 SoC.
This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.
Signed-off-by: Simon Horman <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds