On 08/16/2017 01:10 PM, Jiandi An wrote:

Technically the same check added in msm_gpio_irq_mask() and 
msm_gpio_irq_unmask() should be added in msm_gpio_irq_ack(), 
msm_gpio_irq_set_type(), and msm_gpio_irq_set_wake() if it's registered 
with irq domain.

I assume that if the GPIO is never unmasked, then msm_gpio_irq_ack() 
will never be called.

msm_gpio_irq_set_type() and msm_gpio_irq_set_wake() might be called, so 
I can add checks for those functions.  I'm hoping that won't be 
necessary, however.  The GPIO and IRQ code is too entangled for me to 
figure out whether unclaimed GPIOs can still have their interrupts 
programmed.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.