Thread (20 messages) 20 messages, 6 authors, 2017-08-31

[RFC PATCH v9 1/7] edac: thunderx: Remove suspend/resume support

From: Jan Glauber <hidden>
Date: 2017-08-31 08:46:25
Also in: lkml

On Wed, Aug 30, 2017 at 07:54:06PM +0200, Borislav Petkov wrote:
On Tue, Aug 29, 2017 at 03:12:32PM +0200, Jan Glauber wrote:
quoted
The memory controller on ThunderX/OcteonTX systems does not
support power management. Therefore remove the suspend/resume
callbacks.

Signed-off-by: Jan Glauber <redacted>
---
 drivers/edac/thunderx_edac.c | 21 ---------------------
 1 file changed, 21 deletions(-)
Just when I thought I'd pick that one up now because it is removing
stuff:

drivers/edac/thunderx_edac.c:817:14: error: ?thunderx_lmc_suspend? undeclared here (not in a function)
  .suspend  = thunderx_lmc_suspend,
              ^~~~~~~~~~~~~~~~~~~~
drivers/edac/thunderx_edac.c:818:14: error: ?thunderx_lmc_resume? undeclared here (not in a function)
  .resume   = thunderx_lmc_resume,
              ^~~~~~~~~~~~~~~~~~~
scripts/Makefile.build:308: recipe for target 'drivers/edac/thunderx_edac.o' failed
make[1]: *** [drivers/edac/thunderx_edac.o] Error 1
make[1]: *** Waiting for unfinished jobs....
Makefile:1682: recipe for target 'drivers/edac/' failed
make: *** [drivers/edac/] Error 2
Argh... forgot to build test the single patches. 
Please make sure you build and test every patch before submitting.
You're lucky I can at least build arm64 on my x86 workstation. :-)
Sorry for that. The whole series builds because I removed the suspend/resume
callbacks during the move to the soc driver.

--Jan
Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help