Thread (29 messages) 29 messages, 2 authors, 2017-08-23

[PATCH 11/18] rpmsg: glink: Use the local intents when receiving data

From: Sricharan R <hidden>
Date: 2017-08-22 12:39:09
Also in: linux-arm-msm, linux-remoteproc, lkml

Hi,

<snip..>
quoted
? -??? /* Might have an ongoing, fragmented, message to append */
-??? if (!channel->buf) {
-??????? channel->buf = kmalloc(chunk_size + left_size, GFP_ATOMIC);
-??????? if (!channel->buf)
-??????????? return -ENOMEM;
+??? if (glink->intentless) {
+??????? /* Might have an ongoing, fragmented, message to append */
+??????? if (!channel->buf) {
+??????????? intent = kzalloc(sizeof(*intent), GFP_ATOMIC);
+??????????? if (!intent)
+??????????????? return -ENOMEM;
+
+??????????? intent->data = kmalloc(chunk_size + left_size,
+?????????????????????????? GFP_ATOMIC);
Who is supposed to free the intent and intent->data memory ?
 Well, that's done as a part of the rx_done_work.

Regards,
 Sricharan
 
-- 
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help