Thread (20 messages) flat view 20 messages, 4 authors, 2017-12-23

[RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

From: jeffy <hidden>
Date: 2017-08-18 08:32:47
Also in: linux-pci, linux-rockchip, lkml

Hi Shawn,

On 08/18/2017 03:23 PM, Shawn Lin wrote:
quoted
@@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct
platform_device *pdev)
      struct device *dev = &pdev->dev;
      struct rockchip_pcie *rockchip = dev_get_drvdata(dev);
+    dev_pm_clear_wake_irq(dev);
+    device_init_wakeup(dev, false);
+
Looks good overall but I think we need this on the
error handling path of rockchip_pcie_probe as well?
hmm, right, will fix it, thanks.

and i also notice some other missing error handling, will fix them too:)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help