Thread (29 messages) 29 messages, 4 authors, 2019-01-21

[PATCH 3/8] gpio: zynq: Shift zynq_gpio_init() to subsys_initcall level

From: Linus Walleij <hidden>
Date: 2017-08-14 13:55:59
Also in: linux-gpio, lkml

On Mon, Aug 7, 2017 at 1:01 PM, Michal Simek [off-list ref] wrote:
From: Nava kishore Manne <redacted>

In general situation on-SoC GPIO controller drivers should be probed
after pinctrl/pinmux controller driver, because on-SoC GPIOs utilize a
pin/pad as a resource provided and controlled by pinctrl subsystem.

  GPIO must come after pinctrl as gpios may need to mux pins....etc

Looking at Xilinx SoC series pinctrl drivers, zynq*_pinctrl_init()
functions are called at arch_initcall init levels,
so the change of initcall level for gpio-zynq driver from
postcore_initcall to subsys_initcall level is sufficient. Also note
that the most of GPIO controller drivers settled at subsys_initcall
level.

If pinctrl subsystem manages pads with GPIO functions, the change is
needed to avoid unwanted driver probe deferrals during kernel boot.

Signed-off-by: Nava kishore Manne <redacted>
Signed-off-by: Michal Simek <redacted>
Can't you just move it all the way to device_initcall and
simply use the standard module init macros?
builtin_platform_driver(), module_platform_driver()?

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help