Thread (18 messages) 18 messages, 4 authors, 2017-08-14

[PATCH v4 2/9] mtd: nand: sharpsl.h: support partition parser types

From: Boris Brezillon <hidden>
Date: 2017-08-13 07:40:24
Also in: linux-mmc, lkml

Le Wed, 28 Jun 2017 22:30:29 +0200,
Andrea Adami [off-list ref] a ?crit :

Please add a commit message explaining why you're doing that.
quoted hunk ↗ jump to hunk
Signed-off-by: Andrea Adami <redacted>
---
 include/linux/mtd/sharpsl.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/include/linux/mtd/sharpsl.h b/include/linux/mtd/sharpsl.h
index 65e91d0..c0e0be2 100644
--- a/include/linux/mtd/sharpsl.h
+++ b/include/linux/mtd/sharpsl.h
@@ -17,4 +17,5 @@ struct sharpsl_nand_platform_data {
 	const struct mtd_ooblayout_ops *ecc_layout;
 	struct mtd_partition	*partitions;
 	unsigned int		nr_partitions;
+	const char *const	*types;	/* names of parsers to use if any */
types is not really descriptive here. How about 'part_parsers' or
something clearly reflecting the purpose of this field.

BTW, try to avoid putting comments on the same line.
 };
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help