Thread (18 messages) 18 messages, 5 authors, 2017-08-09

[PATCH 5/6] drm/rockchip: vop: report error when check resource error

From: Sandy Huang <hidden>
Date: 2017-08-04 00:57:13
Also in: dri-devel, linux-rockchip, lkml

Hi mark,

? 2017/7/31 17:49, Mark Yao ??:
quoted hunk ↗ jump to hunk
The user would be confused while facing a error commit without
any error report.

Signed-off-by: Mark Yao <redacted>
---
  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index fa0d9f7..999c2e0 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -674,8 +674,10 @@ static int vop_plane_atomic_check(struct drm_plane *plane,
  	 * Src.x1 can be odd when do clip, but yuv plane start point
  	 * need align with 2 pixel.
  	 */
-	if (is_yuv_support(fb->format->format) && ((state->src.x1 >> 16) % 2))
+	if (is_yuv_support(fb->format->format) && ((state->src.x1 >> 16) % 2)) {
+		DRM_ERROR("Invalid Source: Yuv format not support odd xpos\n");
  		return -EINVAL;
+	}
  
  	return 0;
  }
Reviewed-by: Sandy huang <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help