[RFC PATCH v1] net: ethernet: nb8800: Reset HW block in ndo_open

Mason [off-list ref] writes:

On 29/07/2017 14:05, M?ns Rullg?rd wrote:

quoted

Mason writes:

quoted

I'll take this opportunity to change flow control to
off by default (it breaks several 100 Mbps switches).

I was told to have it on by default.  This is what most other drivers
do too.  If you have faulty switches, that's your problem.

Or maybe the fault is in the HW implementation, and
it is the board's fault that the connection is hosed.

How many switches did you test the driver on?

We tested 4 switches, and DHCP failed on 3 of them.
Disabling pause frames "fixed" that.

Do those switches work with other NICs?

I could spend weeks testing dozens of switches, but
I have to prioritize. Ethernet flow control is simply
not an important feature in the market the SoC is
intended for.

Sure, flow control is rarely needed with well behaved systems.

-- 
M?ns Rullg?rd