[PATCH 13/16] drm/mediatek: Convert to new iterator macros
From: Daniel Vetter <hidden>
Date: 2017-07-12 09:45:03
Also in:
dri-devel, intel-gfx, linux-mediatek
On Wed, Jul 12, 2017 at 10:13:41AM +0200, Maarten Lankhorst wrote:
quoted hunk ↗ jump to hunk
for_each_obj_in_state is about to be removed, so use the new atomic iterator macros. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: CK Hu <redacted> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: linux-arm-kernel at lists.infradead.org Cc: linux-mediatek at lists.infradead.org --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 56f802d0a51c..be0741638f94 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c@@ -48,11 +48,11 @@ static void mtk_atomic_schedule(struct mtk_drm_private *private, static void mtk_atomic_wait_for_fences(struct drm_atomic_state *state) { struct drm_plane *plane; - struct drm_plane_state *plane_state; + struct drm_plane_state *new_plane_state; int i; - for_each_plane_in_state(state, plane, plane_state, i) - mtk_fb_wait(plane->state->fb); + for_each_new_plane_in_state(state, plane, new_plane_state, i) + mtk_fb_wait(new_plane_state->fb); }
I think a variant of drm_atomic_set_fence_for_plane, which takes a reservation obj (or a dma-buf and then derefs dma_buf->resv itself) would be nice, so that drivers don't have to hand-roll sub-par fence waiting code like this (it's e.g. not interruptible for blocking commits). Anyway, patch itself looks good. Reviewed-by: Daniel Vetter <redacted>
static void mtk_atomic_complete(struct mtk_drm_private *private, -- 2.11.0 _______________________________________________ dri-devel mailing list dri-devel at lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch