Thread (2 messages) flat view 2 messages, 2 authors, 2017-07-28

[PATCH v2] arm64: dts: cavium: fix PCI bus dtc warnings

From: robh@kernel.org (Rob Herring)
Date: 2017-07-28 02:15:17
Also in: linux-devicetree

On Thu, Jul 27, 2017 at 8:43 PM, Jayachandran C
[off-list ref] wrote:
On Wed, Jul 26, 2017 at 04:09:43PM -0500, Rob Herring wrote:
quoted
dtc recently added PCI bus checks. Fix these warnings:

arch/arm64/boot/dts/cavium/thunder2-99xx.dtb: Warning (pci_bridge): Node /pci missing bus-range for PCI bridge
arch/arm64/boot/dts/cavium/thunder2-99xx.dtb: Warning (unit_address_vs_reg): Node /pci has a reg or ranges property, but no unit name

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Jayachandran C <redacted>
---
v2:
- Reapply broadcom vulkan changes to thunder2.

 arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
index 4220fbdcb24a..ea50c1320bf7 100644
--- a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
+++ b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
@@ -98,7 +98,7 @@
              clock-output-names = "clk125mhz";
      };

-     pci {
+     pci at 30000000 {
              compatible = "pci-host-ecam-generic";
              device_type = "pci";
              #interrupt-cells = <1>;
@@ -118,6 +118,7 @@
              ranges =
                <0x02000000    0 0x40000000    0 0x40000000    0 0x20000000
                 0x43000000 0x40 0x00000000 0x40 0x00000000 0x20 0x00000000>;
+             bus-range = <0 0xff>;
              interrupt-map-mask = <0 0 0 7>;
              interrupt-map =
                    /* addr  pin  ic   icaddr  icintr */
Thanks for fixing this up.

Acked-by: Jayachandran C <redacted>

The unit name issue is there with memory node on thunder2-99xx.dts as well, I can fix
this up if you are not planning to.
Please do. There are lots more warnings (tree wide) and I don't plan
to fix all of them.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help