[RFC PATCH 1/4] serial: uartps: Remove console_initcall from the driver
From: Michal Simek <hidden>
Date: 2017-07-31 07:37:42
Also in:
linux-serial, lkml
From: Michal Simek <hidden>
Date: 2017-07-31 07:37:42
Also in:
linux-serial, lkml
On 21.7.2017 17:47, S?ren Brinkmann wrote:
On Fri, 2017-07-21 at 11:32:24 +0200, Michal Simek wrote:quoted
register_console() is called from uart_add_one_port()->uart_configure_port() that's why register_console() is called twice. This patch remove console_initcall to call register_console() only from one location. Also based on my tests cdns_uart_console_setup() is not called from the first register_console() call. Signed-off-by: Michal Simek <redacted> --- I am not quite sure about this because console_initcall is called early but I can see any difference in usage. pl011 is not calling this but others are doing it.Doesn't this break early console/printk? I would expect that the UART initialization may happen later than console init.
as I said. I can't see any issue with it. Definitely please try. Thanks, Michal