[PATCH v5 08/19] coresight tmc: Add helpers for accessing 64bit registers

[PATCH v5 00/19] coresight: Support for ARM Coresight SoC-600 · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 03/19] arm: qcom-msm8974: dts: Update coresight replicator · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
Re: [PATCH v5 03/19] arm: qcom-msm8974: dts: Update coresight replicator · Suzuki K Poulose <Suzuki.Poulose@arm.com> · 2017-07-27
Re: [PATCH v5 03/19] arm: qcom-msm8974: dts: Update coresight replicator · Andy Gross <hidden> · 2017-07-27
[PATCH v5 02/19] arm64: juno: dts: Use the new coresight replicator string · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
Re: [PATCH v5 02/19] arm64: juno: dts: Use the new coresight replicator string · Liviu Dudau <liviu.dudau@arm.com> · 2017-07-20
Re: [PATCH v5 02/19] arm64: juno: dts: Use the new coresight replicator string · Sudeep Holla <hidden> · 2017-07-27
[PATCH v5 01/19] coresight replicator: Cleanup programmable replicator naming · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 06/19] coresight: Add support for reading 64bit registers · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 08/19] coresight tmc: Add helpers for accessing 64bit registers · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
Re: [PATCH v5 08/19] coresight tmc: Add helpers for accessing 64bit registers · Mathieu Poirier <mathieu.poirier@linaro.org> · 2017-07-24
Re: [PATCH v5 08/19] coresight tmc: Add helpers for accessing 64bit registers · Suzuki K Poulose <Suzuki.Poulose@arm.com> · 2017-07-25
[PATCH v5 11/19] coresight tmc: Handle configuration types properly · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 13/19] coresight tmc: Detect support for scatter gather · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 12/19] coresight tmc etr: Add capabilitiy information · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 18/19] coresight tmc: Add support for Coresight SoC 600 TMC · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
Re: [PATCH v5 18/19] coresight tmc: Add support for Coresight SoC 600 TMC · Mathieu Poirier <mathieu.poirier@linaro.org> · 2017-07-24
Re: [PATCH v5 18/19] coresight tmc: Add support for Coresight SoC 600 TMC · Suzuki K Poulose <Suzuki.Poulose@arm.com> · 2017-07-25
[PATCH v5 19/19] coresight: Add support for Coresight SoC 600 components · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 17/19] coresight tmc: Support for save-restore in ETR · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 16/19] coresigh tmc etr: Setup AXI cache encoding for read transfers · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 15/19] coresight tmc etr: Cleanup AXICTL register handling · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 14/19] coresight tmc etr: Detect address width at runtime · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 10/19] coresight replicator: Expose replicator management registers · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 09/19] coresight tmc: Expose DBA and AXICTL · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 07/19] coresight: Use the new helper for defining registers · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 05/19] coresight: Extend the PIDR mask to cover relevant bits in PIDR2 · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
[PATCH v5 04/19] arm64: qcom-msm8916: dts: Update coresight replicator · Suzuki K Poulose <suzuki.poulose@arm.com> · 2017-07-20
Re: [PATCH v5 00/19] coresight: Support for ARM Coresight SoC-600 · Mathieu Poirier <mathieu.poirier@linaro.org> · 2017-07-24
Re: [PATCH v5 00/19] coresight: Support for ARM Coresight SoC-600 · Suzuki K Poulose <Suzuki.Poulose@arm.com> · 2017-07-25

From: Suzuki.Poulose@arm.com (Suzuki K Poulose)
Date: 2017-07-25 09:29:35
Also in: lkml

On 24/07/17 18:11, Mathieu Poirier wrote:

On 20 July 2017 at 04:17, Suzuki K Poulose [off-list ref] wrote:

quoted

Coresight TMC splits 64bit registers into a pair of 32bit registers
(e.g DBA, RRP, RWP). Provide helpers to read/write to these registers.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h
index 51c0185..c78de00 100644
--- a/drivers/hwtracing/coresight/coresight-tmc.h
+++ b/drivers/hwtracing/coresight/coresight-tmc.h

@@ -18,6 +18,7 @@
 #ifndef _CORESIGHT_TMC_H
 #define _CORESIGHT_TMC_H

+#include <linux/io.h>

Is this needed?  I recompiled on my side without it and nothing breaks.

I think it is a left over from rebase, where I initially open coded the
read/write_relaxed here and then later moved to the coresight-priv.h. So,
yes, please could you fix it up when you commit ?

Cheers
Suzuki

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help