Hi Baruch,

On Wed, 19 Jul 2017 07:49:23 +0300
Baruch Siach [off-list ref] wrote:

Hi Yong,

On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote:

quoted

On Tue, 18 Jul 2017 14:55:30 +0300
Baruch Siach [off-list ref] wrote:

quoted

I am trying to get this driver working on the Olimex A33 OLinuXino. I 
didn't get it working yet, but I had some progress. See the comment below 
on one issue I encountered.

On Tue, Jun 27, 2017 at 07:07:34PM +0800, Yong Deng wrote:

quoted

Add binding documentation for Allwinner CSI.

Signed-off-by: Yong Deng <yong.deng@magewell.com>
---

[...]

quoted

quoted

quoted

+Example:
+
+	csi1: csi at 01cb4000 {
+		compatible = "allwinner,sun8i-v3s-csi";
+		reg = <0x01cb4000 0x1000>;

You use platform_get_resource_byname() to get this IO resource. This requires 
adding mandatory

  reg-names = "csi";

But is it actually needed? Wouldn't a simple platform_get_resource() be 
enough?

You are right.
This will be fixed in the next version.
I am waiting for more comments for the sunxi-csi.h. It's pleasure if
you have any suggestions about it.

You mean sunxi_csi.h, right?

Yes. My spelling mistake.

Why do you need the sunxi_csi_ops indirection? Do you expect to add 
alternative implementations of these ops at some point?

I want to seperate the sunxi_video.c and sunxi_csi_v3s.c. 
sunxi_csi_v3s.c is Soc specific. Maybe there will be sunxi_csi_r40.c
in the futrue. But the sunxi_video.c and sunxi_csi.c are common.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Thanks,
Yong