On 07/12/2017 02:13 PM, Eric Anholt wrote:

"Gustavo A. R. Silva" [off-list ref] writes:

quoted

This structure is only used to copy into other structure, so declare
it as const.

This issue was detected using Coccinelle and the following semantic patch:

Acked-by: Eric Anholt <redacted>

Thank you, Eric

quoted

---
  drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index 2308831..7203f35 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c

@@ -353,7 +353,7 @@ static int bcm2835_gpio_direction_output(struct gpio_chip *chip,
  	return pinctrl_gpio_direction_output(chip->base + offset);
  }
  
-static struct gpio_chip bcm2835_gpio_chip = {
+static const struct gpio_chip bcm2835_gpio_chip = {
  	.label = MODULE_NAME,
  	.owner = THIS_MODULE,
  	.request = gpiochip_generic_request,

-- 
2.5.0

-- 
Gustavo A. R. Silva