Thread (24 messages) 24 messages, 5 authors, 2017-06-19

[PATCH v4 03/11] net: mvmdio: use GENMASK for masks

flat view
STALE3397d

From: David Laight <hidden>
Date: 2017-06-19 11:57:51
Also in: netdev

From: Antoine Tenart
Sent: 14 June 2017 16:49
Cosmetic patch to use the GENMASK helper for masks.
...
-	ret = val & 0xFFFF;
+	ret = val & GENMASK(15, 0);
My 2c: It isn't at all clear to me that changes like this in anyway
improve the code readability.
In some sense the '15' should be a named constant - but that just makes
it even less obvious what is going on.

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help