[PATCH 3/4] arm64: dts: marvell: Enable second SDHCI controller in Armada 37xx

Hi Thomas,
 
 On mar., juin 13 2017, Thomas Petazzoni [off-list ref] wrote:

Hello,

On Tue, 13 Jun 2017 12:10:29 +0200, Gregory CLEMENT wrote:

quoted

quoted

quoted

+				reg = <0xd0000 0x300
+				       0x1e808 0x4>;  

I'd prefer:

				reg = <0xd0000 0x300>, <0x1e808 0x4>;  

For this one I think it is a matter of taste. I had a look on the other
files and it seems more common to put them on multi lines that on one
single line. And personally I prefer it, for me it seems more visible
that we use 2 set of registers.

I'm not talking about multiple lines vs. one line. I'm talking about:

	reg = <X Y
	       A B>;

vs.

	reg = <X Y>,
	      <A B>;

OK, this case I agree! And I also have to fix this file for the existing
sdhci and xor node.

Gregory

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com