[RFC 2/2] soc: bcm: brcmstb: PM: Implement target_state callback
From: Rafael J. Wysocki <hidden>
Date: 2017-06-29 23:12:05
Also in:
linux-pm, lkml
On Thursday, June 22, 2017 06:08:37 PM Florian Fainelli wrote:
quoted hunk ↗ jump to hunk
Provide a target_state callback implementation which just returns the suspend_state_t the system is about to enter. Broadcom STB drivers can utilize platform_suspend_target_state() to retrieve that and take appropriate actions (e.g: full vs. partial re-initialization). Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/soc/bcm/brcmstb/pm/pm-arm.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)diff --git a/drivers/soc/bcm/brcmstb/pm/pm-arm.c b/drivers/soc/bcm/brcmstb/pm/pm-arm.c index 4b7e6c297b23..7d4695734093 100644 --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c@@ -104,6 +104,7 @@ struct brcmstb_pm_control { u32 phy_b_standby_ctrl_offs; bool needs_ddr_pad; struct platform_device *pdev; + suspend_state_t pm_state;
I wouldn't use suspend_state_t here, because the mapping between those things and real platform power states is somewhat arbitrary and totally platform-specific. It's better to define symbols representing platform power states for your platform (or use an enum) and then use those symbols in the drivers IMO. Thanks, Rafael