Thread (6 messages) 6 messages, 4 authors, 2017-07-03

[PATCH 1/1] futex: remove duplicated code and fix UB

From: Will Deacon <hidden>
Date: 2017-06-26 12:08:20
Also in: linux-alpha, linux-arch, linux-mips, linux-s390, linux-sh, linuxppc-dev, lkml, sparclinux

On Mon, Jun 26, 2017 at 02:02:31PM +0200, Jiri Slaby wrote:
On 06/23/2017, 09:51 AM, Thomas Gleixner wrote:
quoted
On Wed, 21 Jun 2017, Jiri Slaby wrote:
quoted
diff --git a/arch/arm64/include/asm/futex.h b/arch/arm64/include/asm/futex.h
index f32b42e8725d..5bb2fd4674e7 100644
--- a/arch/arm64/include/asm/futex.h
+++ b/arch/arm64/include/asm/futex.h
@@ -48,20 +48,10 @@ do {									\
 } while (0)
 
 static inline int
-futex_atomic_op_inuser(unsigned int encoded_op, u32 __user *uaddr)
That unsigned int seems to be a change from the arm64 tree in next. It's
not upstream and it'll cause a (easy to resolve) conflict.
Ugh, I thought the arm64 is in upstream already. Note that this patch
just takes what is in this arm64 fix and makes it effective for all
architectures. So I will wait with v2 until it merges upstream.

So, Will, will you incorporate Thomas' comments into your arm64 fix?
I wasn't planning to (it's already queued and I think they're just cosmetic
changes). The easiest thing is probably for you to make the changes in the
generic version when you post v2.

Will
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help