On 20-06-17, 17:31, Saravana Kannan wrote:

On 06/19/2017 11:17 PM, Viresh Kumar wrote:

quoted

On Thu, Jun 8, 2017 at 1:25 PM, Dietmar Eggemann
[off-list ref] wrote:

quoted

diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c

quoted

 static int __init register_cpufreq_notifier(void)
 {
+       int ret;
+
        /*
         * on ACPI-based systems we need to use the default cpu capacity
         * until we have the necessary code to parse the cpu capacity, so

@@ -225,8 +265,14 @@ static int __init register_cpufreq_notifier(void)

        cpumask_copy(cpus_to_visit, cpu_possible_mask);

-       return cpufreq_register_notifier(&init_cpu_capacity_notifier,
-                                        CPUFREQ_POLICY_NOTIFIER);
+       ret = cpufreq_register_notifier(&init_cpu_capacity_notifier,
+                                       CPUFREQ_POLICY_NOTIFIER);

Wanted to make sure that we all understand the constraints this is going to add
for the ARM64 platforms.

With the introduction of this transition notifier, we would not be able to use
the fast-switch path in the schedutil governor. I am not sure if there are any
ARM platforms that can actually use the fast-switch path in future or not
though. The requirement of fast-switch path is that the freq can be changed
without sleeping in the hot-path.

So, will we ever want fast-switching for ARM platforms ?

I don't think we should go down a path that'll prevent ARM platform from
switching over to fast-switching in the future.

Yeah, that's why brought attention to this stuff.

I think this patch doesn't really need to go down the notifiers way.

We can do something like this in the implementation of
topology_get_freq_scale():

        return (policy->cur << SCHED_CAPACITY_SHIFT) / max;

Though, we would be required to take care of policy structure in this
case somehow.

Having said that, I'm not sure I fully agree with the decision to completely
disable notifiers in the fast-switching case. How many of the current users
of notifiers truly need support for sleeping in the notifier?

Its not just about sleeping here. We do not wish to call too much
stuff from scheduler hot path. Even if it doesn't sleep.

Why not make
all the transition notifiers atomic? Or at least add atomic transition
notifiers that can be registered for separately if the client doesn't need
the ability to sleep?

Most of the clients don't seem like ones that'll need to sleep.

Only if the scheduler maintainers agree to getting these notifiers
called from hot path, which I don't think is going to happen.

There are a bunch of generic off-tree drivers (can't upstream them yet
because it depends on the bus scaling framework) that also depend on CPUfreq
transition notifiers that are going to stop working if fast switching
becomes available in the future. So, this decision to disallow transition
notifiers is painful for other reasons too.

I think its kind of fine to work without fast switch in those cases,
as we are anyway ready to call notifiers which may end up taking any
amount of time.

This case was special as it is affecting entire arch here and so I
pointed it out.

-- 
viresh