On Tue, 2017-06-20 at 07:01 +0200, Oleksij Rempel wrote:

On 19.06.2017 13:35, Leonard Crestez wrote:

quoted

On Mon, 2017-06-19 at 07:02 +0200, Oleksij Rempel wrote:

quoted

Export pm_power_off_prepare. It is needed to implement power off on
Freescale/NXP iMX6 based boards with external power management
integrated circuit (PMIC).

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
?kernel/reboot.c | 1 +
?1 file changed, 1 insertion(+)

diff --git a/kernel/reboot.c b/kernel/reboot.c
index bd30a973fe94..a6903bf772c7 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c

@@ -49,6 +49,7 @@ int reboot_force;

? */

?void (*pm_power_off_prepare)(void);
+EXPORT_SYMBOL(pm_power_off_prepare);

Could you register a reboot notifier in the pfuze driver instead? Right
now the only user of pm_power_off_prepare is ACPI so this alternative
seems less intrusive.

hm... in this case i will need to make sure that reboot handler is not?
executed on reboot. This will make code looks strange. Which is opposite?
of your comment in other email about strange standby code for power off :)
Should i really do this?

A reboot handler receives a parameter to differentiate between reboot
and shutdown so it would be easy. Isn't it preferable to use an
existing mechanism instead of exporting a new symbol?

But maybe somebody else will Ack this, I don't particularly insist on
changing this.

--
Regards,
Leonard